Szelethus added inline comments.
================
Comment at: test/Analysis/ctor-uninitialized-member-inheritance.cpp:24
+ : NonPolymorphicLeft1(int{}) {
+ y = 420;
+ z = 420;
----------------
Szelethus wrote:
> whisperity wrote:
> > The literal `420` is repeated //everywhere// in this file. I think this
> > (the same value appearing over and over again) will make debugging bad if
> > something goes haywire and one has to look at memory dumps,
> > control-flow-graphs, etc.
> Would you say that I should rather use a different number for each test case?
I mean, a different number for each variable within a test case.
https://reviews.llvm.org/D45532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
