xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Overall looks good, some minor nits inline. If those can be resolved
trivially, I am ok with committing this without another round of reviews.
================
Comment at: unittests/AST/ASTImporterTest.cpp:91
+static void createVirtualFileIfNeeded(ASTUnit *ToAST, StringRef FileName,
+ const std::string &Code) {
+ return createVirtualFileIfNeeded(
----------------
If we already touching this part, maybe better to take the code as a StringRef?
================
Comment at: unittests/AST/ASTImporterTest.cpp:356
+ ImportAction(StringRef FromFilename, StringRef ToFilename,
+ const std::string &DeclName)
+ : FromFilename(FromFilename), ToFilename(ToFilename),
----------------
Maybe using StringRef for DeclName too?
================
Comment at: unittests/AST/ASTImporterTest.cpp:416
+ AllASTUnits[Filename] = Found->getValue().createASTUnits(Filename);
+ BuiltASTs[Filename] = true;
+ }
----------------
Do we need this? Can't we just say if a filename is in `AllASTUnits`, it is
built?
Repository:
rC Clang
https://reviews.llvm.org/D44079
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
