efriedma added inline comments.
================ Comment at: lib/Basic/FrontendTiming.cpp:18 + +bool FrontendTimesIsEnabled = false; + ---------------- avt77 wrote: > efriedma wrote: > > Why is this in lib/Basic, when the declaration is in > > include/clang/Frontend/? > Because this library is being linked to all others and as result this global > variable could be seen in any Clang library w/o any changes in config files. > Or you mean it should be moved from Frontend? But where? It's a frontend > feature that's why I put its declaration there. The include structure should match the library structure; if the definition needs to be in lib/Basic/, the declaration should be in include/clang/Basic. https://reviews.llvm.org/D45619 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
