avt77 added inline comments.
================ Comment at: test/Frontend/ftime-report-template-decl.cpp:2 +// RUN: %clang %s -S -o - -ftime-report 2>&1 | FileCheck %s +// RUN: %clang %s -S -o - -fdelayed-template-parsing -DDELAYED_TEMPLATE_PARSING -ftime-report 2>&1 | FileCheck %s + ---------------- efriedma wrote: > What is this test supposed to be testing? If you're just checking that we > output the timers, this doesn't need to be so complicated. > > We generally prefer to use %clang_cc1 for tests like this. > > Please use -emit-llvm instead of -S if you don't actually need assembly. You wrote "What is this test supposed to be testing? If you're just checking that we output the timers, this doesn't need to be so complicated." I'm going to use this test to show new timers soon that's why it looks so complicated at the first glance. At the moment it simply checking the output of the existing counter but later it will show the new counters. https://reviews.llvm.org/D45619 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
