martong added a comment.
This patch does not target `testImport` because I am not sure how to handle the
options there:
auto RunOptsFrom = getRunOptionsForLanguage(FromLang);
auto RunOptsTo = getRunOptionsForLanguage(ToLang);
for (const auto &FromArgs : RunOptsFrom)
for (const auto &ToArgs : RunOptsTo)
EXPECT_TRUE(testImport(FromCode, FromArgs, ToCode, ToArgs,
Verifier, AMatcher));
I think, it is overkill to test all possible combinations of the options, we
should come up with something better here.
Perhaps we could exploit parameterized tests here as well. @a.sidorin,
@xazax.hun What is your opinion?
Repository:
rC Clang
https://reviews.llvm.org/D47367
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
