martong added a comment.

> I agree with that. I think we need to test just import pairs 
> {/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2, 
> option_2}, ...{option_n, option_n}.

This patch does exactly that with the parameterized tests. Each elements of the 
`DefaultTestValuesForRunOptions` will be used both for the "To" and for the 
"From" context.
So we will have each TEST_P generating 4 cases:
[FROM, TO]
{no_option, no_option}
{"-fdelayed-template-parsing", "-fdelayed-template-parsing"}
{"-fms-compatibility", "-fms-compatibility"}
{"-fdelayed-template-parsing -fms-compatibility", "-fdelayed-template-parsing 
-fms-compatibility"}


Repository:
  rC Clang

https://reviews.llvm.org/D47367



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to