ebevhan added a comment. With the exception of the two inline comments, this looks good to me now!
================ Comment at: include/clang/Basic/LangOptions.def:301 +LANGOPT(FixedPointEnabled, 1, 0, "Fixed point types are enabled") + ---------------- Just a minor nit... The 'Enabled' is superfluous. ================ Comment at: include/clang/Driver/Options.td:882 +def enable_fixed_point : Flag<["-", "--"], "enable-fixed-point">, Group<fixed_point_Group>, + Flags<[CC1Option]>, HelpText<"Enable fixed point types">; ---------------- Shouldn't this be an `-f` flag, like `-ffixed-point`? I'm not for or against either, just wondering what anyone else thinks. Repository: rC Clang https://reviews.llvm.org/D46084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
