leonardchan added inline comments.
================ Comment at: include/clang/Basic/TokenKinds.def:393 +// ISO/IEC JTC1 SC22 WG14 N1169 Extension +KEYWORD(_Accum , KEYALL) + ---------------- jfb wrote: > ebevhan wrote: > > I believe that having KEYALL will enable the keyword even if > > -fno-fixed-point is given. Is this desired? It will mean that `_Accum` will > > not be a valid identifier in standard C regardless of the flag. > That seems fine: identifiers starting with underscore and a capital letter > already aren't valid identifiers in C and C++ because they're reserved for > the implementation. I think my test for `-fno-fixed-point` already catches this, but I did not notice until now the `KEYNOCXX` keyword until now. Using this instead allows for not having to check if the language is c++ since `_Accum` is no longer treated as a typename. The corresponding test checking fixed points in c++ has been updated to reflect this. Repository: rC Clang https://reviews.llvm.org/D46084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
