probinson added a comment. LGTM with the indicated test tweak, but best if @filcab also takes a look.
================ Comment at: lib/Driver/ToolChains/PS4CPU.cpp:87 + CmdArgs.push_back("--dependent-lib=libSceDbgAddressSanitizer_stub_weak.a"); + } +} ---------------- Don't bother with braces for a one-line `if` body. ================ Comment at: test/Driver/fsanitize.c:624 +// CHECK-ASAN-PS4: --dependent-lib=libSceDbgAddressSanitizer_stub_weak.a // CHECK-ASAN-PS4-NOT: {{(\.(o|bc)"? |-l).*-lSceDbgAddressSanitizer_stub_weak}} // CHECK-ASAN-PS4: -lSceDbgAddressSanitizer_stub_weak ---------------- Repeat this NOT line before the new check? to preserve the property described in the comment. Repository: rC Clang https://reviews.llvm.org/D47375 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits