rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/CodeGenCXX/override-bit-field-layout.cpp:5-12
+struct S {
+  short a : 3;
+  short b : 5;
+};
+
+void use_structs() {
+  S ss[sizeof(S)];
----------------
Another relevant test:

```
struct T {
  virtual void f();
  short x : 3;
};
```

Because we don't do vfptr layout adjustments when using an external layout 
source, I think this would have put `x` at offset 0 instead of at offset 8 
prior to your patch.


Repository:
  rC Clang

https://reviews.llvm.org/D49227



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D49227: O... Aleksandr Urakov via Phabricator via cfe-commits
    • [PATCH] D492... Shoaib Meenai via Phabricator via cfe-commits
    • [PATCH] D492... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D492... Aleksandr Urakov via Phabricator via cfe-commits
    • [PATCH] D492... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D492... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D492... Aleksandr Urakov via Phabricator via cfe-commits

Reply via email to