Cees Hek wrote:
Quoting Michael Peters <[EMAIL PROTECTED]>:

The CGIAppPluginMethod attribute seems to be a bit long. Is it possible to shorten it to say 'plugin_method' or something like that. I seriously doubt that anyone who uses a base class called 'CGI::Application::Plugin' won't know that the method they are marking as a 'plugin_method' is for a CGI::Application.


The reason I picked a very descriptive attribute names is so that it doesn't
conflict with any other attributes or modules.  I agree that it is long, and it
can be shortened, but I want to make sure that it is still descriptive.

This same plugin technique is also used in Maypole, and Class::DBI where they
use the attributes named Exported and Plugged respectively.  The reason the
attribute name was changed was so that users that used both Maypole and
Class::DBI in the same project would not have methods imported into the wrong
modules.  ie if both of them used the Exported attribute, there would be a
possibility that some methods destined for Maypole would accidentally get
imported into Class::DBI.  Chaos ensues...

Ok, I agree that it should be something that designates it as C::A and not some other modules plugin. Maybe we can jump on the bandwagon of other C::A methods and use 'cgiapp_plugged' or something like that. Just a thought, and a small one at that.



See the following thread for more info: http://groups.kasei.com/mail/arc/cdbi-talk/2004-06/msg00145.html


This still doesn't address the issue that we was discussed many moons ago about the ability to register multiple callbacks for the init, prerun, postrun, etc, stages. We will need to address this before we move much further (although this seems to be an issue with C::A and not with your plugin structure)


So far I have been able to work around these issues, so I haven't pushed things
too much.

Which issues did you have to work around. If I recall correctly there were some about cleaning up database handles, etc in the teardown stage. If your session module uses file drivers by default then it won't use the database stuff. I couldn't remember off hand any specific issues that would need to register callback hooks. Anyone else remember?


Michael Peters
Developer
Plus Three

---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/[EMAIL PROTECTED]/
             http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to