On Mon, Jan 13, 2014 at 09:31:39AM +0100, Lukas Fleischer wrote: > This patch is quite messy and hard to read. I read your cover-letter but > maybe you still want to clean this up when dealing with the other > suggestions during a rebase -- shouldn't be too hard when using an > editor with good Git integration (like fugitive for Vim). > > On Mon, 13 Jan 2014 at 05:11:13, Jason A. Donenfeld wrote: > > [...] > > +ifdef NO_LUA > > We should document this in the installation instructions section in the > README. I also wonder whether this should made an opt-in feature? > > > + CFLAGS += -DNO_LUA > > +else > > + CGIT_LIBS += -llua > > Similar: Add Lua/LuaJIT (Will you squash the LuaJIT Makefile fix into > this one? Or is there any reason to use Lua first and switch to LuaJIT > later?) to the dependencies section of the README file and mention that > it is optional.
I think we should support both vanilla Lua and LuaJIT if we can (I believe LuaJIT can be used as a drop-in replacement, so there's no reason this shouldn't be possible). > > +endif > > + > > +CGIT_LIBS += -ldl > > + > > + > > + > > CGIT_OBJ_NAMES += cgit.o > > CGIT_OBJ_NAMES += cache.o > > CGIT_OBJ_NAMES += cmd.o > > [...] _______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
