On 13.01.2014 05:11, Jason A. Donenfeld wrote: > Signed-off-by: Jason A. Donenfeld <[email protected]> > --- > cgit.h | 2 +- > cgit.mk | 13 ++- > filter.c | 284 > ++++++++++++++++++++++++++++++++++++++++++++++++---------------
All those *_lua_filter functions look rather self contained, maybe they should be split into filter_lua.c for readability? Also I'm not sure why documenting the filter and adding error reporting to totally new code go into separate commits. They are one logical change after all. As Lukas already said it's probably a lot better if you split the cleanup and moving-stuff-around into it's own patch. (Or merge it into "basic write hooking infrastructure" since you create that code there so it should be created at the correct place)
signature.asc
Description: OpenPGP digital signature
_______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
