Ted Leung wrote:
> I think that you should be asking why there are single commits of
> 500k.   That's an unreviewable size...

While I agree we should aim for small change sets, I don't think that is
always possible to break commits into sane subsets. I believe it is
possible to review large changes, but of course it makes it harder.

Yesterday's large commit was mostly string and comment changes, so it
was easier to review than most. It could easily have been broken down
per directory, but logically one checkin made more sense.

-- 
  Heikki Toivonen


Attachment: signature.asc
Description: OpenPGP digital signature

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev

Reply via email to