Brad, That is OK with me. A comment ahead of the commented out lines about why they're commented out may prevent them coming back a fourth time without a good fix.
David On 04/10/2014 01:50 PM, Brad Chamberlain wrote: > PS -- I'll take the "OK to commit" from anyone -- just called out Michael > and Tom because they've been the ones struggling to get these lines > into the compiler in a portable way. > > > On Thu, 10 Apr 2014, Brad Chamberlain wrote: > >> Hi Tom/Michael/developers -- >> >> I'm looking for a quick review/sign-off on the following change to qio.h >> which comments out the developer-oriented, off-by-default debugging output >> capability (for those keeping score, this'll be the third time I've backed >> out this same code for portability reasons!). >> >> For some reason, it's choking when using the Cray C++ compiler, similarly to >> what's described in this stackoverflow thread (which doesn't include a >> satisfactory fix): >> >> >> http://stackoverflow.com/questions/14535556/why-doesnt-priu64-work-in-this-code >> >> I'm proposing just commenting the code out rather than trying to find a >> "right" way to fix it for the sake of getting the release out ASAP. We >> arguably made the mistake of only trying to build with RE2 on Cray systems >> too late in this release cycle. >> >> Thanks, >> -Brad >> >> >> Index: runtime/include/qio/qio.h >> =================================================================== >> --- runtime/include/qio/qio.h (revision 23189) >> +++ runtime/include/qio/qio.h (working copy) >> @@ -738,14 +738,14 @@ >> static inline >> void qio_channel_retain(qio_channel_t* ch) { >> DO_RETAIN(ch); >> - if (ch&& DEBUG_QIO) >> - fprintf(stdout, "Channel retain %p, ref_cnt = %" PRIu64 "\n", ch, >> DO_GET_REFCNT(ch)); >> + // if (ch&& DEBUG_QIO) >> + // fprintf(stdout, "Channel retain %p, ref_cnt = %" PRIu64 "\n", ch, >> DO_GET_REFCNT(ch)); >> } >> >> static inline >> void qio_channel_release(qio_channel_t* ch) { >> - if (ch&& DEBUG_QIO) >> - fprintf(stdout, "Channel release %p, ref_cnt = %" PRIu64 "\n", ch, >> DO_GET_REFCNT(ch)); >> + // if (ch&& DEBUG_QIO) >> + // fprintf(stdout, "Channel release %p, ref_cnt = %" PRIu64 "\n", ch, >> DO_GET_REFCNT(ch)); >> DO_RELEASE(ch, _qio_channel_destroy); >> } >> > ------------------------------------------------------------------------------ > Put Bad Developers to Shame > Dominate Development with Jenkins Continuous Integration > Continuously Automate Build, Test& Deployment > Start a new project now. Try Jenkins in the cloud. > http://p.sf.net/sfu/13600_Cloudbees > _______________________________________________ > Chapel-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/chapel-developers ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers
