Commenting out the offending lines is fine with me too. THH ________________________________________ From: [email protected] [[email protected]] Sent: Thursday, April 10, 2014 1:04 PM To: Brad Chamberlain; David Iten Cc: [email protected] Subject: Re: [Chapel-developers] [patch] fix RE2 for Cray compiler
It's OK with me to comment out these lines too. I don't generally use the PRIu64 etc macros in debugging code... I prefer to just cast everything to int/long int. Furthermore, I don't think this is a generally useful debugging facility (although it might matter at some point in the future... a developer can always add back in the relevant prints). So, I guess I'm saying it'd also be OK with me to entirely remove those lines. -michael ________________________________________ From: Brad Chamberlain [[email protected]] Sent: Thursday, April 10, 2014 15:26 To: David Iten Cc: [email protected] Subject: Re: [Chapel-developers] [patch] fix RE2 for Cray compiler Good point, thanks! -Brad On Thu, 10 Apr 2014, David Iten wrote: > Brad, > > That is OK with me. A comment ahead of the commented out lines about why > they're commented out may prevent them coming back a fourth time without a > good fix. > > David > > On 04/10/2014 01:50 PM, Brad Chamberlain wrote: >> PS -- I'll take the "OK to commit" from anyone -- just called out Michael >> and Tom because they've been the ones struggling to get these lines >> into the compiler in a portable way. >> >> >> On Thu, 10 Apr 2014, Brad Chamberlain wrote: >> >>> Hi Tom/Michael/developers -- >>> >>> I'm looking for a quick review/sign-off on the following change to qio.h >>> which comments out the developer-oriented, off-by-default debugging output >>> capability (for those keeping score, this'll be the third time I've backed >>> out this same code for portability reasons!). >>> >>> For some reason, it's choking when using the Cray C++ compiler, similarly >>> to >>> what's described in this stackoverflow thread (which doesn't include a >>> satisfactory fix): >>> >>> >>> http://stackoverflow.com/questions/14535556/why-doesnt-priu64-work-in-this-code >>> >>> I'm proposing just commenting the code out rather than trying to find a >>> "right" way to fix it for the sake of getting the release out ASAP. We >>> arguably made the mistake of only trying to build with RE2 on Cray systems >>> too late in this release cycle. >>> >>> Thanks, >>> -Brad >>> >>> >>> Index: runtime/include/qio/qio.h >>> =================================================================== >>> --- runtime/include/qio/qio.h (revision 23189) >>> +++ runtime/include/qio/qio.h (working copy) >>> @@ -738,14 +738,14 @@ >>> static inline >>> void qio_channel_retain(qio_channel_t* ch) { >>> DO_RETAIN(ch); >>> - if (ch&& DEBUG_QIO) >>> - fprintf(stdout, "Channel retain %p, ref_cnt = %" PRIu64 "\n", ch, >>> DO_GET_REFCNT(ch)); >>> + // if (ch&& DEBUG_QIO) >>> + // fprintf(stdout, "Channel retain %p, ref_cnt = %" PRIu64 "\n", ch, >>> DO_GET_REFCNT(ch)); >>> } >>> >>> static inline >>> void qio_channel_release(qio_channel_t* ch) { >>> - if (ch&& DEBUG_QIO) >>> - fprintf(stdout, "Channel release %p, ref_cnt = %" PRIu64 "\n", ch, >>> DO_GET_REFCNT(ch)); >>> + // if (ch&& DEBUG_QIO) >>> + // fprintf(stdout, "Channel release %p, ref_cnt = %" PRIu64 "\n", >>> ch, >>> DO_GET_REFCNT(ch)); >>> DO_RELEASE(ch, _qio_channel_destroy); >>> } >>> >> >> ------------------------------------------------------------------------------ >> Put Bad Developers to Shame >> Dominate Development with Jenkins Continuous Integration >> Continuously Automate Build, Test& Deployment >> Start a new project now. Try Jenkins in the cloud. >> http://p.sf.net/sfu/13600_Cloudbees >> _______________________________________________ >> Chapel-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/chapel-developers > > ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers
