Issue 2988: sdch/open-vcdiff breaks build on Linux http://code.google.com/p/chromium/issues/detail?id=2988
Comment #2 by craig.schlenter: Two issues: 1. sdch/SConscript has an AutoConfig that is supposed to make a config.h with the correct defines ... this doesn't seem to work as far as I can tell. The resultant Hammer/sdch/open-vcdiff/src/config.h has everything undefined and commented out. 2. Even when that is fixed to have some defines in the code, it still doesn't work as the config.h file only seems to say things like #define HAS_whatever. Nothing is using those defines to include the correct headers from what I can tell but I haven't spent a ton of time trying to make sense of it. I'd expect to see something going: #ifdef whatever #include <correctheader.h> #endif --Craig -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
