Issue 2662: Get open-vcdiff building on Linux and Mac
http://code.google.com/p/chromium/issues/detail?id=2662

Comment #9 by craig.schlenter:
The fedora 9 version of g++ is pretty cutting edge and it seems to be  
pickier about
namespace issues. Here's the compile output when I revert the fix for  
logging.cc

[open-vcdiff-read-only]$ svn revert src/logging.cc
Reverted 'src/logging.cc'
[open-vcdiff-read-only]$ make
if /bin/sh ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.  
-I./src
-I./src  -DNDEBUG -Wall -Wwrite-strings -Woverloaded-virtual -W -g -O2 -MT  
logging.lo
-MD -MP -MF ".deps/logging.Tpo" -c -o logging.lo `test -f 'src/logging.cc' | 
| echo
'./'`src/logging.cc; \
        then mv -f ".deps/logging.Tpo" ".deps/logging.Plo"; else rm  
-f ".deps/logging.Tpo";
exit 1; fi
  g++ -DHAVE_CONFIG_H -I. -I. -I./src -I./src -DNDEBUG -Wall -Wwrite-strings
-Woverloaded-virtual -W -g -O2 -MT logging.lo -MD -MP -MF .deps/logging.Tpo  
-c
src/logging.cc  -fPIC -DPIC -o .libs/logging.o
src/logging.cc: In function 'void open_vcdiff::DefaultExitFatal()':
src/logging.cc:23: error: 'exit' was not declared in this scope
make: *** [logging.lo] Error 1
[open-vcdiff-read-only]$ g++ --version
g++ (GCC) 4.3.0 20080428 (Red Hat 4.3.0-8)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I've submitted the CLA electronically.

Thanks!



-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to