Comment #8 on issue 4830 by [email protected]: [Alt+Shift+T]: Strange  
behavior with return key on Save As dialog.
http://code.google.com/p/chromium/issues/detail?id=4830

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=7406

------------------------------------------------------------------------
r7406 | [email protected] | 2008-12-22 20:32:34 -0800 (Mon, 22 Dec 2008) |  
23 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/base_button.cc?r1=7406&r2=7405

Fix 4830: We navigate back after closing the Save As dialog.

If you use Alt-Shift-T and the arrow keys to go to the Page menu
and then launch the Save Page As dialog, we would navigate back after
saving the page.

This is because once we close the Save As dialog with Enter, focus
goes to the Back button (which arguable is also wrong, see issue 5750)
and it receives a KeyRelease(Enter), which causes us to navigate back
right after saving the page.

In Windows, pressing Enter while a button has focus clicks the button
on KeyPressed, whereas we currently click the button on KeyRelease.

This patch makes Chrome mimic native Windows behavior. We retain
the current behavior for Space, however, which clicks on KeyReleased
in both Chrome and Windows.

BUG=4830
TEST=Native Chrome buttons should click buttons on KeyPress when using
Enter and on KeyRelease when using Space.

Review URL: http://codereview.chromium.org/16202
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to