Updates:
Cc: [email protected] [email protected] [email protected]
[email protected] [email protected]
Labels: -Pri-2 -Area-Misc Pri-3 Area-BrowserUI Mstone-X I18N RTL
Comment #1 on issue 6085 by [email protected]: The Chrome system menu is not
mirrored in RTL locales
http://code.google.com/p/chromium/issues/detail?id=6085
comments thread:
==================================================================================
From Idan
This is not only a translation issue. This is also an issue of the menu not
using an
RTL layout; that is, the little icons should appear on the right hand side,
the text
should be right aligned, etc.
I haven't looked into this yet but my guess is that there is a way to tell
Windows
that the menu should use an RTL layout and we probably won't need to
translate
'close', 'minimize', etc. because Windows will do it automatically as long
as we
create the menu properly.
==================================================================================
From Tony
We have strings for minimize/maximize/restore/close, but it doesn't look
like we're
using them. We're just sending a WM_SYSCOMMAND message and letting Windows
display
the system menu. This causes the system menu to show up in the language
that Windows
is in.
I'm not sure what the right thing to do here is. E.g., if you right click
on the
task bar, it seems like the system menu should be in Windows' language.
Also, it
doesn't look like Firefox translates the system menu either (in fact, the
whole title
bar is drawn by Windows and is LTR).
==================================================================================
From Idan
Thanks for the clarification, Tony.
My original explanation for this bug wasn't completely accurate. We
certainly don't
have to worry about translating the 'close', 'minimize', etc. strings. I ran
"chrome.exe --lang=he" on an English version of Windows and on a Hebrew
version of
Windows and the system menu's text was properly translated to Hebrew on the
Hebrew
Windows and was not translated on the English Windows. So what Tony
described about
how Windows displays the system menu text is correct.
However, even though the menu is translated, it is still not using the
desired RTL
layout and I think we should fix that by making sure that we create the
menu with the
RTL layout property if the locale is RTL. This solution has two caveats and
they are
both manifested when running "chrome.exe --lang=he" on an English version
of Windows
(on the Hebrew version everything looks well). First, the menu will have
English text
that is right aligned, which is not the most elegant. Second, the system
related text
("close", "minimize", etc), will be in English, but the "Task Manager" will
be
translated to Hebrew. Both of these problems happen because Chrome loads
its strings
based on the locale and Windows loads the system menu's strings based on
the shell's
language (aka the UI language).
I am not sure I understand the point about Firefox because as far as I can
tell
Firefox (at least the version I tested) is not localized to Hebrew. I ran
Firefox on
the Hebrew version of Windows and its system menu is translated to Hebrew
and uses
the same incorrect LTR layout Chrome currently uses. This makes sense
because
Firefox's HWND does not have the WS_EX_LAYOUTRTL set (which explains why
the title
bar is drawn LTR by Windows) and therefor its system menu uses an LTR
layout.
Chrome's UI is localized to Hebrew so it makes sense to mirror the system
menu
together with everything else in the UI that we mirror. Am I missing
something here?
==================================================================================
From Tony:
Sorry, I should have been more clear. You can get a Hebrew version of
Firefox here:
http://www.mozilla.com/en-US/firefox/all-beta.html
I'm not sure what Hebrew Firefox does on Hebrew Windows.
So it sounds like the bug is that we need to make the System Menu layout
RTL in RTL
languages.
I'm not sure what to do about the mixed languages in the System Menu, but
this will
be true of any Chrome language that doesn't match the Windows language.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
