Comment #5 on issue 6175 by [email protected]: REGRESSION: Google
Spreadsheets doesn't work
http://code.google.com/p/chromium/issues/detail?id=6175
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12390
------------------------------------------------------------------------
r12390 | [email protected] | 2009-03-24 13:26:40 -0700 (Tue, 24 Mar 2009)
| 30 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/README.google?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/public/common/unicode/ucnv.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv2022.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_bld.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_bld.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_ext.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_ext.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_lmb.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnv_set.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnvhz.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnvmbcs.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/ucnvmbcs.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/common/uset_imp.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/cintltst/ncnvtst.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/cintltst/nucnvtst.c?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/intltest/convtest.cpp?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/intltest/convtest.h?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/testdata/Makefile.in?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/testdata/conversion.txt?r1=12390&r2=12389
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/test/testdata/testdata.mak?r1=12390&r2=12389
A
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/uconv.security.header.patch
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/uconv.security.patch?r1=12390&r2=12389
Apply ICU patches for ICU tickets 6175 (ISO-2022 and
HZ empty segment handling bug) and 5691 (Mulibyte encoding
invalid sequence handling bug).
The patch for ICU ticket 5691 was back ported before (r4302,
crbug.com/2074), but that for 6175 has not been. I was mistaken that
Webkit-based browsers are not affected by this issue, but recently I found
that Apple had
fixed it in their copy of ICU in May 2008 (thanks to Adam). And more
importantly, we are affected even though I can't come up with an actual
exploit case in a web browser (On the server-side, this can be a real
issue) as opposed to a simple alert box coming up.
To make applying the patch easier, I consolidated the patches for
ICU tickets 5691 and 6175 along with patches for other ICU tickets
listed below into a single patch file (uconv.security.patch). We can
live without the patches for tickets other than 6175 and 5691, but it makes
easier to maintain our copy of ICU with them applied together. As a
side-benefit(?), GB-HZ converter that was not fixed in r4302 is also fixed
(it does not really matter because we don't support GB-HZ, but just in
case ...)
http://icu-project.org/trac/ticket/6001 (r22849, 22851)
http://icu-project.org/trac/ticket/6002 (r22847, 22850)
http://icu-project.org/trac/ticket/6071 (r23041)
http://icu-project.org/trac/ticket/6175 (r23571, 23572)
http://icu-project.org/trac/ticket/6358 (r24245)
http://icu-project.org/trac/ticket/6412 (r24468)
http://icu-project.org/trac/ticket/5691
(r24733,24769,24770,24773,24778,24824,24825)
TEST=
1. Go to https://bug381412.bugzilla.mozilla.org/attachment.cgi?id=267398
and see a bunch of 'inverse question marks' for U+FFFD. Also, hovering the
mouse over 'aaa' should not bring up an alert box. A real layout test will
be added later.
2. chrome/fast/encoding/Invalid_multibyte-over-consumption.html
BUG=2074,3823
Review URL: http://codereview.chromium.org/52030
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
