Comment #18 on issue 8544 by [email protected]: Crash - SafeBrowsingResourceHandler::OnUrlCheckResult http://code.google.com/p/chromium/issues/detail?id=8544
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13644
------------------------------------------------------------------------
r13644 | [email protected] | 2009-04-13 19:03:20 -0700 (Mon, 13 Apr 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.h?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/worker_host/worker_service.cc?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/worker_host/worker_service.h?r1=13644&r2=13643
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=13644&r2=13643
Fix a crash where the ResourceMessageFilter is deleted before a
SafeBrowsing check has completed. The problem occurs since the
SafeBrowsingResourceHandler is not deleted when its associated
URLRequest is cleaned up *and* a SafeBrowsing check is in progress.
When the check completes, the next resource handler in the chain
(the AsyncResourceHandler which caches a pointer the now deleted
ResourceMessageFilter) will crash.
This CL adds a notification for objects to know when the
ResourceMessageFilter is destroyed.
BUG=8544 (http://crbug.com)
Review URL: http://codereview.chromium.org/63036
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
