Comment #7 on issue 15852 by [email protected]: Incorrect keycode with
dvorak keyboard layout on Linux
http://code.google.com/p/chromium/issues/detail?id=15852
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20369
------------------------------------------------------------------------
r20369 | [email protected] | 2009-07-10 01:32:28 -0700 (Fri, 10 Jul 2009)
| 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp?r1=20369&r2=20368
A quick fix for Issue 15852.
After a discussion in <http://crbug.com/15852>, I noticed I wrongly
understood the Dvorak and European keyboards. We should not use US layout
for handling shortcut keys. To fix this problem, this change uses |
event->hardware_keycode| only when WebKit::windowsKeyCodeForKeyEvent()
returns 0. When we use the Hebrew (or Russian) layout, |event->keyval|
becomes GDK_hebrew_* (or GDK_Cyrillic_*) and this function returns 0.)
BUG=15852 "Incorrect keycode with dvorak keyboard layout on Linux"
TEST=Open <http://www.asquare.net/javascript/tests/KeyCode.html>, press 'x'
of a dvorak keyboard, and its keyDown.keyCode becomes 88.
Review URL: http://codereview.chromium.org/149248
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
