Comment #11 on issue 8727 by [email protected]: Linux dialogs are
application-modal rather than window-modal
http://code.google.com/p/chromium/issues/detail?id=8727
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20667
------------------------------------------------------------------------
r20667 | [email protected] | 2009-07-14 14:33:42 -0700 (Tue, 14 Jul 2009)
| 35 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc?r1=20667&r2=20666
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=20667&r2=20666
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/dialogs_gtk.cc?r1=20667&r2=20666
Make GTK file dialog box modal for parent window, instead of for the entire
application.
This works by adding the GtkWindow in BrowserWindowGtk to its own
GtkWindowGroup and adding the SelectFile dialog to the same group. The
following call to gtk_grab_add(...) makes the SelectFile dialog modal, but
only to the windows within the same group.
Similarly, the bookmark manager window is also added to its own unique
GtkWindowGroup, so the import/export dialogs behave correctly.
If I'm understanding things correctly, the GtkWindowGroup objects are
reference counted once the have windows attached to them, and will delete
themselves after all references to them are destroyed. I'm not sure how to
verify this.
Test:
- Open two new chrome window: A and B
- Open "Save file as..." dialog in window A
- Verify that window A does not respond to keyboard or mouse events.
- Verify that window B does responde to keyboard and mouse events.
- Open "Save file as..." dialog in window B
- Verify that window B does not respond to keyboard or mouse events.
- Cancel dialog on window A.
- Verify that window A starts responding to keyboard and mouse events.
- Cancel dialog on window B.
- Verify that window B starts responding to keyboard and mouse events.
BUG=8727
patch by Mohit Muthanna <[email protected]>
original review URL: http://codereview.chromium.org/149548
Review URL: http://codereview.chromium.org/155518
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
