Comment #17 on issue 8727 by [email protected]: Linux dialogs are
application-modal rather than window-modal
http://code.google.com/p/chromium/issues/detail?id=8727
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21207
------------------------------------------------------------------------
r21207 | [email protected] | 2009-07-21 13:19:34 -0700 (Tue, 21 Jul 2009)
| 43 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc?r1=21207&r2=21206
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=21207&r2=21206
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/dialogs_gtk.cc?r1=21207&r2=21206
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/info_bubble_gtk.cc?r1=21207&r2=21206
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=21207&r2=21206
Make GTK file dialog box modal for parent window, instead of for the entire
application.
This works by adding the top-level GtkWindow objects, such as
BrowserWindowGtk
and BookmarkManagerGtk, to their own unique window groups. Without this
change,
all top-level windows are added to a default application-wide window group.
This ensures that all grabs created with gtk_grab_add(...) only affect the
window group of the grabbed widget, as opposed to the entire application.
Note that gtk_window_set_modal(...) is implemented with gtk_grab_add(...)
and
therefore is only modal to a specific window group.
In order for this to work correctly, changes were also made to the info
bubble and render widget popup (<select> tag) code. Since these widgets
also call gtk_grab_add(...), they must be added to the top level window
group to work correctly.
Test 1:
- Open two new chrome window: A and B
- Open "Save file as..." dialog in window A
- Verify that window A does not respond to keyboard or mouse events.
- Verify that window B does responde to keyboard and mouse events.
- Open "Save file as..." dialog in window B
- Verify that window B does not respond to keyboard or mouse events.
- Cancel dialog on window A.
- Verify that window A starts responding to keyboard and mouse events.
- Cancel dialog on window B.
- Verify that window B starts responding to keyboard and mouse events.
Test 2:
- Verify that <select> tag allows for correct selection of items.
Test 3:
- Click bookmark star and verify that info bubble works correctly.
BUG=8727
TEST=none
patch by Mohit Muthanna Cheppudira <mohit.muthanna [at] gmail>
original review url: <http://codereview.chromium.org/155852>
Review URL: http://codereview.chromium.org/159147
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
