Comment #17 on issue 16246 by [email protected]: Quick back/forward navigations close the tab http://code.google.com/p/chromium/issues/detail?id=16246
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21531
------------------------------------------------------------------------
r21531 | [email protected] | 2009-07-24 08:57:39 -0700 (Fri, 24 Jul 2009)
| 20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/mock_render_process_host.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_process_host.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=21531&r2=21530
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=21531&r2=21530
Fix a race condition where rapid back/forward clicks could close a tab
This can be triggered when you're on the new tab page, going to *two* other
sites, then rapidly hitting back and forward randomly. If a cross-site
transition was canceled before the original page responds with an "OK to
close
me" message, it will mistakenly categorize the close as not just for the
RenderView (correspondong to one side of the cross-site transition) but for
the
entire tab.
This change adds an explicit parameter on the messages indicating whether
it's
for interstials or for the tab so we don't have to rely on the request still
being active.
This also adds the "requesting process + route" in addition to the
"new process + request" so we can be more clear about sending the messages
to
the correct place. The previous patch conbimed these in a confusing way.
BUG=16246
TEST=none
Review URL: http://codereview.chromium.org/159255
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
