Comment #8 on issue 5022 by [email protected]: remove ATL dependencies from test_shell http://code.google.com/p/chromium/issues/detail?id=5022
How nice is "nice"? The above couple changes are fine because they're just as short and readable as the old code, and in the case of gfx::Point, slightly more cross- platform. The change to remove CWindowImpl from ForegroundWindow, OTOH, makes the code noticeably longer and less clear, with more annoying fiddly details to do precisely the kind of junk ATL does for you. I am much more interested in code readability than building with VC Express. The benefit of building with the Express compiler is dubious (the set of developers who (a) produce useful contributions, (b) don't develop on Linux or Mac, and (c) don't have/can't afford a normal copy of Visual Studio seems likely to be very small), but the cost of not using ATL in some of these cases is noticeable. Someone should make it clear why VC Express support is worth this tradeoff. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
