Comment #10 on issue 5022 by [email protected]: remove ATL dependencies from test_shell http://code.google.com/p/chromium/issues/detail?id=5022
OK, I chatted with Ben some this morning and I think we have resolution. I don't have any love for ATL per se; I'm merely opposed to boilerplate, and I like things like message cracking macros and not setting up window pointers oneself, etc. Ben tells me that WidgetWin used to be a CWindowImpl, and that dependency was removed. There are two notable bits here: it can still use the message-cracking macros, because they come from atlcrack.h, which, despite its name, is actually part of WTL instead of ATL; and it now has to do a lot of the same boilerplate we're doing in the latest patch here. Therefore, Ben's suggestion is to hoist the portion of the boilerplate that's needed by all such classes to some place in views/ (if webkit/tools can depend on that) or else base/ (if not); and to continue using the macros in atlcrack.h. This makes me happy as within a particular class things are still as readable and boilerplate-free as possible. How's that sound? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
