Comment #11 on issue 6442 by [email protected]: Malware redirects should be blocked http://code.google.com/p/chromium/issues/detail?id=6442
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23616
------------------------------------------------------------------------
r23616 | [email protected] | 2009-08-17 23:24:03 -0700 (Mon, 17 Aug 2009) |
21 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/chrome_plugin_host.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/net/url_fetcher.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/plugin_process_host.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/renderer_host/resource_dispatcher_host.h?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/common/chrome_plugin_unittest.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/proxy/proxy_script_fetcher.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/tools/testserver/testserver.py?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request.h?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_job.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_job.h?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_unittest.cc?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/net/url_request/url_request_unittest.h?r1=23616&r2=23615
M
http://src.chromium.org/viewvc/chrome/branches/172/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc?r1=23616&r2=23615
Merge r21417 to 172.
(Part 1, r22067 to follow)
Add support to URLRequest for deferring redirects.
I chose to add an out parameter to OnReceivedRedirect because it allows for
the
default behavior to remain the same.
I considered adding a ContinueAfterRedirect method that all
OnReceivedRedirect
implementations would need to call, but this caused one annoying problem:
In
the case of a ChromePlugin, it is possible for the URLRequest to get deleted
inside the handler for the redirect. This would make it hard to
subsequently
call a method on the URLRequest since I would need to have a way to
determine
if the URLRequest had been deleted.
TEST=covered by unit tests
BUG=16413,6442
R=eroman,wtc
Review URL: http://codereview.chromium.org/171099
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
