Comment #3 on issue 20259 by [email protected]: Stop using the ActiveX version of WMP http://code.google.com/p/chromium/issues/detail?id=20259
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25433
------------------------------------------------------------------------
r25433 | [email protected] | 2009-09-03 22:53:23 -0700 (Thu, 03 Sep 2009) |
7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_service.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_messages.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_messages_internal.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_delegate_stub.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_delegate_stub.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_proxy.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/webplugin_proxy.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webplugin_delegate_proxy.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webplugin_delegate_proxy.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugins2.xml?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_delegate.h?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.cc?r1=25433&r2=25432
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.h?r1=25433&r2=25432
This changelist fixes some issues with the NPAPI WMP plugin work in
Chrome. The first is that we need to disable windowless mode since it
doesn't work in the NPAPI plugin (Safari does this as well, and sites don't
use windowless for Firefox). The second is to make UpdateGeometry message
synchronous for WMP. The problem I saw was that while handling that
message, the plugin might disaptch a NPObject Invoke method to play a
video, which WMP doesn't expect and it leads to the video never playing.
While touching these files, I made some small cleanup by reverting the
change that made WebPluginProxy not have a WebPluginDelegateImpl pointer,
which added a bunch of unnecessary methods to WebPluginDelegate.
BUG=20259
TEST=use --no-activex and try playing the videos on
http://www.nana10.co.il/Section/?SectionID=10847&sid=235
Review URL: http://codereview.chromium.org/196012
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
