Comment #2 on issue 15289 by [email protected]: Sharing model of  
{cookie_store_ and proxy_service_} in ChromeURLRequestContext is wrong
http://code.google.com/p/chromium/issues/detail?id=15289

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=25558

------------------------------------------------------------------------
r25558 | [email protected] | 2009-09-04 17:17:14 -0700 (Fri, 04 Sep 2009)  
| 7 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_profile_impl.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_profile_impl.h?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.h?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/cookie_monster.h?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/cookie_monster_unittest.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/cookie_store.h?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_context.h?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=25558&r2=25557
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_request_context.cc?r1=25558&r2=25557

This CL changes the CookieStore obect to be a refcounted object to get a  
better handle on its lifetime as there are cases where this object is  
handed out to URLRequestContext instances which outlive the  
URLRequestContext object which created it.

Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289

Bug=15289

Review URL: http://codereview.chromium.org/197023
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to