Comment #13 on issue 22585 by [email protected]: CMD+Down, CMD+Up no longer scrolling to top/bottom of page http://code.google.com/p/chromium/issues/detail?id=22585
thakis, Sorry for my slow updates. (I have been taking a vacation this week.) You are correct. I also noticed it last Friday while prototyping my idea. Even though I think copying the logic in EditorClientImpl::handleEditingKeyboardEvent() (*1) can solve this problem, I'm wondering if it is a good solution because a copy-and-paste solution makes the Chromium code more complicated and harder to debug. (*1) WebFrameImpl::executeCommand() executes an editor command but returns false if the focused node is not ediable. To share such logic (or magics), I personally preferred adding a method WebViewClient::interpretKeyEvent(), which returns an editor command from a key event, so that it can return the queued edit command instead of looking up a hash table when a browser sent it. (Maybe we need to talk with darin?) Regards, -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
