Comment #16 on issue 22585 by [email protected]: CMD+Down, CMD+Up no
longer scrolling to top/bottom of page
http://code.google.com/p/chromium/issues/detail?id=22585
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27464
------------------------------------------------------------------------
r27464 | [email protected] | 2009-09-28 20:56:51 -0700 (Mon, 28 Sep 2009)
| 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view_unittest.cc?r1=27464&r2=27463
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view_unittest_mac.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/render_view_test.cc?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/render_view_test.h?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.cc?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=27464&r2=27463
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.h?r1=27464&r2=27463
Fix cmd-up/cmd-down.
The approach is to special-case moveToBeginningOfDocument and
moveToEndOfDocument in WebFrameImpl::executeCommand(). With this (and the
cocoa keyboard bindings patch being landed), the special-case code in
WebViewImpl::ScrollViewWithKeyboard() can be removed.
Also add a test for cmd-up/down.
Change chrome.gyp so that it supports osx-only unit tests
(_unittest_mac.mm).
Move OnPrintPageAsBitmap to the other printing tests.
BUG=22585
TEST=Go to a page with both text box and scrollbar (e.g.
http://en.wikipedia.org ). Pressing cmd-down should scroll to end of page,
cmd-up back to start. Clicking the text box and trying some emacs shortcuts
should work (ctrl-a jumps to start of line, cmd-h acts as backspace, etc).
Review URL: http://codereview.chromium.org/254002
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
