To me, it looks like the case where we could create an abstraction, similar to what I did with ExceptionContext, which encapsulates ExecState* and ArgList* on JSC side and provides a way to pass strings/line numbers for V8.
So, at this point I would merge Console.cpp into one two-chunked file (option 1) with the plan to implement and upstream ConsoleContext. ... Perhaps ExceptionContext & ConsoleContext => ScriptContext? :DG< On Tue, Oct 7, 2008 at 2:27 PM, Elliot Glaysher <[EMAIL PROTECTED]> wrote: > As the person who threw together a good chunk of Console.cpp, I'd > prefer that we keep Console.cpp local, at least in the short term > because it's nowhere near complete yet. I'm currently waiting for > crbug.com/2960 to be fixed in V8 so Console output has line numbers, > which will require me to change the declarations in the USE(V8) > section of Console.h so it also takes a line number... > > -- Elliot > > On Tue, Oct 7, 2008 at 2:17 PM, Ojan Vafai <[EMAIL PROTECTED]> wrote: >> If you are helping with the next merge, or with unforking WebKit code, read >> on. Otherwise, don't bother. >> In attempting to get the KJS build compiling I ran into a case that seems >> similar to many of the issues we've run into that required us to move things >> into port. I figured we could talk now about what the right solution is both >> so I can fix the error in front of me and so we'll have a good sense of how >> to move forward on these issues. >> In Console.h, most of the methods take KJS specific types and we fork them >> to take Strings, e.g. >> #if USE(JSC) >> void debug(KJS::ExecState*, const KJS::ArgList&); >> #elif USE(V8) >> void debug(const String& message); >> #endif >> Then we have our own implementation of Console.cpp that implements just the >> V8 methods and is a totally different implementation than the KJS >> equivalents. >> I see a couple solutions: >> 1. Move our V8 implementation of Console.cpp methods into the >> third_party/WebKit one wrapped in "#if USE(V8)". >> 2. Move Console.cpp out of port.vcproj and into V8Bindings.vcproj and >> KJSBindings.vcproj appropriatly. >> Are there other options? Preferences? >> Ojan >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
