Eric asked on #webkit, and (since I don't think they log(?)) I'll just paraphrase a response from there, which is that this is a bad idea since the inspector needs to have all the arguments and not just a single string.
On Tue, Oct 7, 2008 at 2:17 PM, Ojan Vafai <[EMAIL PROTECTED]> wrote: > If you are helping with the next merge, or with unforking WebKit code, read > on. Otherwise, don't bother. > In attempting to get the KJS build compiling I ran into a case that seems > similar to many of the issues we've run into that required us to move things > into port. I figured we could talk now about what the right solution is both > so I can fix the error in front of me and so we'll have a good sense of how > to move forward on these issues. > In Console.h, most of the methods take KJS specific types and we fork them > to take Strings, e.g. > #if USE(JSC) > void debug(KJS::ExecState*, const KJS::ArgList&); > #elif USE(V8) > void debug(const String& message); > #endif > Then we have our own implementation of Console.cpp that implements just the > V8 methods and is a totally different implementation than the KJS > equivalents. > I see a couple solutions: > 1. Move our V8 implementation of Console.cpp methods into the > third_party/WebKit one wrapped in "#if USE(V8)". > 2. Move Console.cpp out of port.vcproj and into V8Bindings.vcproj and > KJSBindings.vcproj appropriatly. > Are there other options? Preferences? > Ojan > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
