On Fri, Nov 28, 2008 at 10:38, Dean McNamee <[EMAIL PROTECTED]> wrote:
> > I'm working on Linux layout tests. We're at about ~85% passing right > now, but I know we still have a lot of problems. > > I've recently been running into places where I'm trying to fix > problems, but the Windows layout test is marked as failing, and the > expected image is either wrong or old. It would be really great if we > had more of the Windows layout tests fixed after the merge of doom. I > know it was hard, and fixing layout tests are boring, but now the > Linux team has no idea what we should be shooting for, and we have > nothing to match. For example, simple tests related to text areas (we > are trying to match metrics) fail: > > [EMAIL PROTECTED]:layout_tests$ grep textarea test_lists/win/tests_fixable.txt > LayoutTests/fast/forms/textarea-scrollbar-height.html = FAIL > chrome/fast/forms/basic-textareas-quirks.html = FAIL > LayoutTests/fast/forms/textarea-rows-cols.html = FAIL > LayoutTests/fast/parser/comment-in-textarea.html = FAIL > LayoutTests/fast/parser/open-comment-in-textarea.html = FAIL > LayoutTests/fast/replaced/width100percent-textarea.html = FAIL > chrome/fast/forms/basic-textareas.html = FAIL > > I have no idea how to continue with the Linux theming work, since we > have no known good to match. I realize that fixing layout tests is > not very attractive work, but there is some responsibility to have a > trunk that is passing these layout tests. > > What should be the plan? Our direction was to work on layout tests > exclusively. Now I am thinking we should work on other areas until > Windows can get it's test coverage back to where it was per-merge, and > then we actually have a baseline to try to match. How about working on fixing the failures on Windows? I'm not trying to burden the messenger here. Everyone should be getting very eager to fix tests on Windows: we can't do a release off of trunk because of the number of test failures (among other things). We're getting close to the end of the usefulness of the 154 branch, but all the great new stuff on trunk is not going to be releasable until we start fixing issues (crashes, layout tests). I also don't want to throw up artificial barriers between platforms. We're just about at parity across all platforms on layout tests. It's time to start treating all the platforms as equally important (well maybe we're not _quite_ there yet). I hope we can avoid fracturing groups along platform lines. We're making progress on the post-merge regressions on Windows, and I hear your warning that if we don't speed up, other things are going to slow down. I'll see what I can do to speed things up next week. Meanwhile, my original suggestion still stands. --Mark > > > -- dean > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
