No, Dean is very much correct. "git cl upload" will upload your patch to the review server and will accept git-diff style arguments (including diffing against a sha1) or will build a patch going back to origin/trunk. It will also store the code review issue number and associate it with your current branch, allowing multiple uploads to the same code review issue.
(git cl dcommit will also close your code review in addition to doing the associated git svn dcommit...) > Unless there is a new addition[...] git cl upload dates back to the very beginning of the git-cl tool. > Clearly you didn't even bother reading my e-mail (I know it was really > long and all) This was entirely unnecessary and inflammatory. -- Elliot On Thu, Dec 4, 2008 at 3:49 PM, Benjamin <[EMAIL PROTECTED]> wrote: > > Clearly you didn't even bother reading my e-mail (I know it was really > long and all) otherwise you would have noticed my one example of the > usage of my script. Here it is again: > > upload-git-patch sha1 > > Unless there is a new addition, last I checked you could not run > 'git-cl sha1' to upload a new patch for review. > > On Thu, Dec 4, 2008 at 3:40 PM, Dean McNamee <[EMAIL PROTECTED]> wrote: >> >> This is exactly what git-cl does. It's what we use, and probably the >> only thing we'll support if we ever "support" git. >> >> On Thu, Dec 4, 2008 at 4:50 PM, Benjamin <[EMAIL PROTECTED]> wrote: >>> >>> I have also written a tool that will upload a git patch. So this way >>> you can have as many branches as you want and commit whenever you want >>> and when you are ready you can just run >>> >>> upload-git-patch sha1 >>> >>> and it will upload that patch using the already committed description. >>> This allows for things like local git hooks, not having to wait on >>> reviews etc. >>> >>> http://github.com/icefox/chromium_tools/tree >>> >>> -Benjamin Meyer >>> >>> On Thu, Dec 4, 2008 at 7:14 AM, Dean McNamee <[EMAIL PROTECTED]> wrote: >>>> >>>> Several of us are already using git. Specifically the Linux >>>> developers are pretty much exclusively using git. There is an >>>> overview of how you might do it here: >>>> >>>> http://dev.chromium.org/developers/how-tos/using-git >>>> >>>> Small correction, we don't use gcl at all when using git, we have a >>>> replacement for uploading to Rietveld, called git-cl. >>>> >>>> On Thu, Dec 4, 2008 at 6:31 AM, Ben Goodger (Google) <[EMAIL PROTECTED]> >>>> wrote: >>>>> >>>>> It's possible to use git with our existing infrastructure before you >>>>> reach the commit to main-line gate. Evan has some scripts that make >>>>> using gcl easier. >>>>> >>>>> However we've not discussed converting wholesale seriously since our >>>>> infrastructure as a whole is tied to svn and it's not trivial (or >>>>> productive) for us to spend a lot of time on something that is mostly >>>>> working right now. >>>>> >>>>> -Ben >>>>> >>>>> On Wed, Dec 3, 2008 at 8:32 PM, Benjamin <[EMAIL PROTECTED]> wrote: >>>>>> >>>>>> Any thoughts on moving to git like the android webkit guys are? I >>>>>> have been using git on windows for about a month now and was expecting >>>>>> it to be absolutely horrible from what everyone said, but found it >>>>>> worked just fine and didn't find anything that got in my way. >>>>>> >>>>>> -Benjamin Meyer >>>>>> >>>>>> On Wed, Dec 3, 2008 at 12:25 AM, Ben Goodger (Google) <[EMAIL >>>>>> PROTECTED]> wrote: >>>>>>> >>>>>>> Google Code's review tool doesn't support flows that require review >>>>>>> before commit or our gcl changelist management script which are both >>>>>>> integral part of the Chromium project development flow. >>>>>>> >>>>>>> -Ben >>>>>>> >>>>>>> On Tue, Dec 2, 2008 at 8:50 PM, empriser <[EMAIL PROTECTED]> wrote: >>>>>>>> >>>>>>>> Hello, >>>>>>>> >>>>>>>> The current review tool has not search opinion, It is unconvinient. >>>>>>>> Why do not use the Google code's review tool ? >>>>>>>> >>>>>>>> Yours sincerely, >>>>>>>> Jack >>>>>>>> >>>>>>>> 2008-12-03 >>>>>>>> > >>>>>>>> >>>>>>> >>>>>>> > >>>>>>> >>>>>> >>>>>> > >>>>>> >>>>> >>>>> > >>>>> >>>> >>>> > >>>> >>> >>> > >>> >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
