IIRC, it used to be that all of webkit/data was a separate checkout so our rebaselined results were a separate dep that you could ignore. It's great for people not working on layout tests. It's kind of a pain for people working on tests because the flow is:
1) send review for rebaseline 2) send review for code changes 3) check in rebaseline 4) check in code changes and roll deps I think people often forgot to roll deps. That said, while I would prefer to have a single repository, I'm not opposed to using deps for this. On Fri, 5 Dec 2008, Brett Wilson wrote: > > Can we structure the directories and deps such that you only need to > specify the layout test results for your platform (or no results at > all like many people do)? > > Brett > > On Fri, Dec 5, 2008 at 2:44 PM, Evan Martin <[EMAIL PROTECTED]> wrote: > > > > On Fri, Dec 5, 2008 at 2:41 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > >> On Fri, Dec 5, 2008 at 2:35 PM, Evan Martin <[EMAIL PROTECTED]> wrote: > >>> However, that will mean the chromium repo (under > >>> webkit/data/layout_tests/platform/chromium-linux) will grow by the > >>> size of this data. For comparison, the chromium-win directory is 4745 > >>> png files, another 4745 checksums, and a total 94 megabytes. Everyone > >>> will now end up checking those out, > >> > >> Don't layout_tests get excluded from the default .gclient? If so, I say > >> just go for this; the penalty will only hit people who check out layout > >> tests. > > > > webkit/data/layout_tests/LayoutTests => points at the WebKit repo and > > contains the enormous test suite > > webkit/data/layout_tests/platform/* => part of our repo (under trunk, > > so not pulled in via DEPS) and includes all our expected > > Windows-baselined output > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
