On Tue, Dec 16, 2008 at 8:26 PM, Mohamed Mansour <[email protected]> wrote: > Awesome John, will save a lot of time for those reviewers. So I assume this > is only for Google code style, webkit patches reviews will always display an > error since they have a different style.
That's correct. The script doesn't catch all style violations, but it should cover enough to save reviewers tedious nitting. > > On Tue, Dec 16, 2008 at 11:20 PM, Adam Barth <[email protected]> wrote: >> >> Awesome! Thanks John. Trailing whitespace be gone! >> >> On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek <[email protected]> >> wrote: >> > >> > Just a heads-up that I've integrated the script into our Rietveld >> > instance. If you use gcl, it will ping the server at a special url >> > after a patchset upload so that it can lint the files in the >> > background. When you visit the issue page, you'll see a "x errors" >> > link under the Lint column which takes you to the lint output. If the >> > file hasn't been linted yet, you'll see "? errors", in which case >> > clicking the link will show the errors and save it for future >> > refreshes of the issue page. >> > >> > On Fri, Dec 5, 2008 at 5:34 AM, Marc-Antoine Ruel <[email protected]> >> > wrote: >> >> >> >> I did an internal search and the current state is: >> >> >> >> - "Folks have been looking at open sourcing cpplint" >> >> - In its current incarnation, there is a lot of google-specific checks >> >> that needs to be factored out simply because they don't apply to >> >> external and open source projects. >> >> - Nobody actually took over to do the work. >> >> >> >> So I wouldn't expect anything in the near term. >> >> >> >> M-A >> >> >> >> On Thu, Dec 4, 2008 at 10:24 PM, Marshall Greenblatt >> >> <[email protected]> wrote: >> >>> Ok, so, back to the original question. When can those of us external >> >>> to >> >>> google expect a code style tool? :-) >> >>> >> >>> On Thu, Dec 4, 2008 at 1:57 PM, Dean McNamee <[email protected]> >> >>> wrote: >> >>>> >> >>>> It doesn't need to be a parser, it's just a linter. You don't really >> >>>> need to understand anything about the program to give useful warnings >> >>>> about style. Our biggest style violation is probably trailing >> >>>> whitespace, for example. >> >>>> >> >>>> On Thu, Dec 4, 2008 at 7:33 PM, Benjamin <[email protected]> wrote: >> >>>> > >> >>>> > You wrote a c++ parser in python? cooool! I can't wait to see the >> >>>> > source. >> >>>> > >> >>>> > -Benjamin Meyer >> >>>> > >> >>>> > On Thu, Dec 4, 2008 at 12:22 PM, Pam Greene <[email protected]> >> >>>> > wrote: >> >>>> >> >> >>>> >> On Wed, Dec 3, 2008 at 8:30 PM, Benjamin <[email protected]> wrote: >> >>>> >>> >> >>>> >>> On Wed, Dec 3, 2008 at 3:45 PM, Marshall Greenblatt >> >>>> >>> <[email protected]> wrote: >> >>>> >>>> Sorry to be a pest, but has there been any progress on this? >> >>>> >>>> >> >>>> >>>> Thanks, >> >>>> >>>> Marshall >> >>>> >>>> >> >>>> >>>> On Thu, Sep 18, 2008 at 4:17 PM, Pam Greene <[email protected]> >> >>>> >>>> wrote: >> >>>> >>>>> >> >>>> >>>>> On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt >> >>>> >>>>> <[email protected]> wrote: >> >>>> >>>>> > Hi Mark/Pam, >> >>>> >>>>> > >> >>>> >>>>> > On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai >> >>>> >>>>> > <[email protected]> >> >>>> >>>>> > wrote: >> >>>> >>>>> >> >> >>>> >>>>> >> Great question. We've been talking about open-sourcing >> >>>> >>>>> >> something >> >>>> >>>>> >> for >> >>>> >>>>> >> this, but so far, we don't have anything yet. We do have >> >>>> >>>>> >> something we >> >>>> >>>>> >> use internally, but someone needs to go through it and clean >> >>>> >>>>> >> up a >> >>>> >>>>> >> few >> >>>> >>>>> >> things before releasing it so that it runs well in the wild. >> >>>> >>>>> >> When it >> >>>> >>>>> >> does materialize, it'll show up on the style guide project >> >>>> >>>>> >> (http://google-styleguide.googlecode.com/). >> >>>> >>>>> > >> >>>> >>>>> > Do you guys have a timeline in mind of when such a tool might >> >>>> >>>>> > become >> >>>> >>>>> > available? If there are potential code licensing/IP issues, >> >>>> >>>>> > perhaps it >> >>>> >>>>> > could be made available as a web-based service? For >> >>>> >>>>> > instance, >> >>>> >>>>> > something >> >>>> >>>>> > like the w3c validator but returning the corrections in >> >>>> >>>>> > either >> >>>> >>>>> > human-readable format or a format conducive to automation. >> >>>> >>>>> >> >>>> >>>>> Everybody's generally in support of open-sourcing the tool, and >> >>>> >>>>> I >> >>>> >>>>> don't anticipate any licensing conflicts; it's just a matter of >> >>>> >>>>> finding the time to go through it. For what it's worth, >> >>>> >>>>> setting it >> >>>> >>>>> up >> >>>> >>>>> as a web-based service wouldn't be any faster. More than days, >> >>>> >>>>> less >> >>>> >>>>> than months, would be my guess. >> >>>> >>>>> >> >>>> >>>>> - Pam >> >>>> >>> >> >>>> >>> A web tool would only delay releasing a real tool. Just curious >> >>>> >>> how >> >>>> >>> is it written? Using llvm, rpp, or another parser? >> >>>> >> >> >>>> >> It's in Python. >> >>>> >> >> >>>> >> - Pam >> >>>> >> >> >>>> >>> >> >>>> >>> -Benjamin Meyer >> >>>> >>> >> >>>> >>> > >> >>>> >>> >> >>>> >> >> >>>> >> > >> >>>> >> >> >>>> > >> >>>> > > >> >>>> > >> >>>> >> >>>> >> >>> >> >>> >> >>> > >> >>> >> >> >> >> > >> >> >> > >> > > >> > >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
