This made a ton of layout tests start failing, most likely we are drawing differently now?
On Thu, Jan 29, 2009 at 3:55 AM, <[email protected]> wrote: > > Author: [email protected] > Date: Wed Jan 28 18:55:36 2009 > New Revision: 8862 > > Log: > Linux: use WebKit HEAD's gtk2drawing.c > > Review URL: http://codereview.chromium.org/18053 > > > Modified: > trunk/src/webkit/build/WebCore/SConscript > trunk/src/webkit/tools/test_shell/test_shell_gtk.cc > > Modified: trunk/src/webkit/build/WebCore/SConscript > ============================================================================== > --- trunk/src/webkit/build/WebCore/SConscript (original) > +++ trunk/src/webkit/build/WebCore/SConscript Wed Jan 28 18:55:36 2009 > @@ -931,7 +931,6 @@ > # Linux specific implementations. > input_files.extend([ > '$WEBCORE_DIR/platform/chromium/FileSystemChromiumLinux.cpp', > - '$WEBCORE_DIR/platform/chromium/gtk2drawing.c', > '$WEBCORE_DIR/platform/chromium/KeyCodeConversionGtk.cpp', > '$WEBCORE_DIR/platform/chromium/ScrollbarThemeChromiumLinux.cpp', > '$WEBCORE_DIR/platform/chromium/SoundChromiumPosix.cpp', > @@ -943,6 +942,8 @@ > '$WEBCORE_DIR/platform/graphics/chromium/IconChromiumLinux.cpp', > '$WEBCORE_DIR/platform/graphics/chromium/SimpleFontDataLinux.cpp', > > + '$WEBCORE_DIR/platform/gtk/gtk2drawing.c', > + > '$WEBCORE_DIR/rendering/RenderThemeChromiumGtk.cpp', > ]) > # Remove from the list files that haven't yet been made portable to Linux. > > Modified: trunk/src/webkit/tools/test_shell/test_shell_gtk.cc > ============================================================================== > --- trunk/src/webkit/tools/test_shell/test_shell_gtk.cc (original) > +++ trunk/src/webkit/tools/test_shell/test_shell_gtk.cc Wed Jan 28 18:55:36 > 2009 > @@ -50,11 +50,17 @@ > > } > > +extern "C" { > + extern gint moz_gtk_init(); > +} > + > // static > void TestShell::InitializeTestShell(bool layout_test_mode) { > window_list_ = new WindowList; > layout_test_mode_ = layout_test_mode; > > + moz_gtk_init(); > + > web_prefs_ = new WebPreferences; > > g_resource_data_pack = new base::DataPack; > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
