> On Thu, Jan 29, 2009 at 7:44 AM, Dean McNamee <[email protected]> wrote: >> >> The files seem quite different >> >> 1 file changed, 336 insertions(+), 835 deletions(-) >> >> Anyone interested in taking a look at this today? >>
Hey Adam, I worked on the gtk2drawing unforking to see why it caused so many test failures. The first problem is that platform/chromium/gtkdrawing.h wasn't unforked as well, so that header was being used instead of the appropriate platform/gtk/gtkdrawing.h. This caused a problem because a new type was added to the GtkThemeWidgetType enum, so when MOZ_GTK_DROPDOWN was requested, we got MOZ_GTK_ENTRY_CARET drawn. Unforking gtkdrawin.h would fix that problem. That fixes about 40 layout tests. The remaining ~100 failures are because of differences in the way the two gtk2drawing.c's render certain widgets. I think chromium's gtk2drawing widgets look a lot better, but another solution is to rebaseline those tests. -- James Hawkins --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
