On Mon, Mar 2, 2009 at 4:31 PM, Erik Kay <[email protected]> wrote: > If we do this, I'd suggest that we leave them in on Chromium builds, > but not Chrome builds rather than Release vs. Debug. I think asking a > user to switch to Debug is a lot worse since it'll also slow them down > a lot. > > As for why people are doing this, it's likely because of the large > number of crashes related to third party DLL injection that turning > off the sandbox fixes. Given this, I'd say that we're not in a > position to remove these flags since they're currently the only > recommended workaround.
Right, I realize there are still compatibility problems, which is why I purposely left --no-sandbox out of the list. If people are using -in-process-plugins or --single-process instead of --no-sandbox, that's worse off.. > > > Erik > > > On Mon, Mar 2, 2009 at 4:25 PM, Elliot Glaysher (Chromium) > <[email protected]> wrote: > > > > +1. We absolutely should do this. > > > > -- Elliot > > > > On Mon, Mar 2, 2009 at 4:16 PM, John Abd-El-Malek <[email protected]> > wrote: > >> I was looking at the second top crasher in 2.0.166.1, and it turned out > that > >> these users are running with --in-process-plugins. This turns off the > >> sandbox and runs plugins in the renderer process. > >> So far we've exposed all the internal command line switches to all > users, > >> but I'm wondering if that has outlived its usefulness. We don't test > either > >> mode on chromebot, while in-process-plugins doesn't even have any tests. > I > >> don't think spending much development time on these modes is worth the > >> opportunity cost. > >> The flip side is in the past they have been useful to have around, i.e. > when > >> someone complains about a bug, we sometimes ask them to try these modes. > >> So I propose that we disable these flags in release builds, and if we > want > >> to test on users, we can point them towards debug builds off the build > >> server. Obviously this is more work for them, but I think this avoids > >> distracting us with looking at modes that are only used by a minority of > >> users, and which we know are already broken. The bigger issue is why > these > >> users used those modes. I think in the past we might have suggested it > to > >> people if they had performance problems etc, but hopefully these are > taken > >> care of by now, and if not, better to know it anyways by having these > users > >> use the standard multi-process mode. > >> Any strong opposition to this? > >> > > >> > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
