Agreed. The current code base has many abstractions that implicitly embody windows assumptions--just porting them is not always the right approach. Sometimes sticking a layer *above* them and putting different mechanisms into play per-platform is a better solution.
--Amanda On Tue, Mar 24, 2009 at 1:06 PM, Thomas Van Lenten <thoma...@chromium.org> wrote: > > > On Tue, Mar 24, 2009 at 1:00 PM, Amanda Walker <ama...@chromium.org> wrote: >> >> 2009/3/24 John Abd-El-Malek <j...@chromium.org>: >> > Right, this is used so that if the user starts Chrome a second time, it >> > tells the currently running exe to open a new tab. This is the standard >> > way >> > of doing it on Windows, but I don't know how Mac/Linux apps enforce >> > single-instance semantics. We should first figure out if this code is >> > needed before porting it.. >> >> Mac OS X handles this via the UI--if you try to launch an >> already-running application through the Finder, Dock, etc., the >> already running instance is brought to the front. While nothing in >> the underlying OS enforces single-instance semantics, the only way to >> get multiple instances within a single user session is to open a >> command line and explicitly launch them (or do the equivalent from >> another program or script). Additional instances can of course be >> launched in other user sessions simply by switching to another session >> and launching the application normally. >> >> It's not at all clear to me that we need to explicitly filter out >> multiple instances on the Mac; if we do, we will need to scope such >> filtering to a single user session, which will require using >> Mac-specific APIs. I would suggest that we postpone this until and >> unless we find a demonstrated need for it. > > The point I was trying to make, is all of this logic, should not be handled > at the process filter layer, the real thing needed here is a higher level > abstraction that capture what we're after (find_running_chromium(), > message_running_chromium(), etc.). The individual platform code can then > implement it w/ process filter or whatever, but trying to wedge it into > working on all platforms via process filter seems wrong. > > TVL > >> >> >> --Amanda > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---