On Wed, Apr 22, 2009 at 11:13 PM, Darin Fisher <da...@chromium.org> wrote:
> IIRC, some people (peter?) have had /usr/bin/svn on their path ahead of > depot_tools, since they don't want our svn interfering with their webkit > checkout. this used to work if you always accessed our svn by calling gvn > instead (yes, i meant gvn). i believe that gcl, like gvn, will also pass > through to svn, but when i try it now, i get a strange error. so, perhaps > no one is counting on this anymore. > Strange error like "Your client is too old" ? That's the main problem with the upgrade. As soon as you do 1 svn update using the svn inside depot tool, you can't use your system svn anymore. Nicolas > > -darin > > > On Wed, Apr 22, 2009 at 9:58 PM, Mark Larson (Google) > <m...@chromium.org>wrote: > >> I filed http://bugs.chromium.org/10872 for this... >> >> >> From src/chrome/tools/build/win/version.bat: >> >> :: Determine the current repository revision number >> set PATH=%~dp0..\..\..\..\third_party\svn;%PATH% >> svn.exe info | grep.exe "Revision:" | cut -d" " -f2- | sed "s/\(.*\)/set >> LASTCHANGE=\1/" >> %VarsBat% >> call %VarsBat% >> >> This calls trunk/deps/third-party/svn/svn.exe, which is not the same >> version as svn in depot_tools. >> >> Result? >> >> Generating version template file >> svn: This client is too old to work with working copy '.'. You need >> to get a newer Subversion client, or to downgrade this working copy. >> See http://subversion.tigris.org/faq.html#working-copy-format-change >> for details. >> >> >> >> My preference would be to remove svn from the tree. We require you to use >> gclient to pull the tree, so you already have svn in one place. If it's >> not >> in your path, I think it's OK for this step to fail (modify the bat file >> to >> point to your copy of svn). >> >> For most users and the buildbots, svn will be in the path. >> >> So just calling 'svn' means version.bat will use the same version that >> gclient used to check out the files. >> >> Any objections to >> >> 1. Pulling deps/third_party/svn out of the tree? >> 2. Changing version.bat to just call 'svn' (expecting it in the path)? >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
