On Thu, Apr 23, 2009 at 6:53 AM, Peter Kasting <[email protected]> wrote: > ...and I have written such code (~1.5 years ago). It was annoying to track > down. Don't be dumb like me. Don't do anything with side effects inside > CHECK(), DCHECK(), or similar.
FWIW, in non-Chromium Google code it is very common to do CHECK(DoImportantWork()), which is why for me it was a hard habit to lose. I was still writing these sorts of bugs occasionally a year after starting on this project. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
