Sadly, chrome/common sounds generic enough that it's become a place to stash files. I'm not blameless - for some reason I put Animation there, when it clearly belongs in views/.
Common's purpose is for files shared between two or more subdirs of chrome where those subdirs are peers on the dependency tree. -Ben On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman <[email protected]> wrote: > > Is it possible to enforce these rules with code rather than capital letters? > > I don't think I've made this particular error, but it's something I > could see myself doing. From their names, "chrome/common" seems like a > reasonable thing to include from "chrome/views". > > Just a thought. Don't we have something already to enforce dependency > rules like this? > > - a > > On Fri, Apr 24, 2009 at 9:59 PM, Ben Goodger (Google) <[email protected]> > wrote: >> >> I have noticed some of these creep in in the past couple of weeks. >> >> DO NOT DO IT. >> >> Or I will hunt you down. >> >> I am trying to extract views from chrome/ and every time you do this, >> it adds spaghetti to the plate and makes my life harder. >> >> -Ben >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
