On Fri, Apr 24, 2009 at 10:19 PM, Brett Wilson <[email protected]> wrote: > On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman <[email protected]> wrote: >> Is it possible to enforce these rules with code rather than capital letters? >> >> I don't think I've made this particular error, but it's something I >> could see myself doing. From their names, "chrome/common" seems like a >> reasonable thing to include from "chrome/views". >> >> Just a thought. Don't we have something already to enforce dependency >> rules like this? > > The problem is that there are already some dependencies, so we can't > enforce them. The dependencies are checked on a per-directory basis. I > would like to prevent people from including browser from renderer_host > and tab_contents but can't for the same reason. We could have some > complicated exception list in the checkdeps tool, but that's much > harder than shouting on the mailing list.
A stupid solution might be to allow a dependency on target_indirection/, and allow target_indirection/ to depend on target/, and have files in target_indirection/ like: file.h: // Copyright blah blah... // If you add dependencies to this file, Ben will harangue you. #include "chrome/target/file.h" As things get detangled, files disappear from target_indirection/ until all are gone! -scott --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
