On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow <[email protected]> wrote:
> Darin was there on that lunch and was actually the one who first suggested > running parts of WebCore in the browser to me during a 1:1. :-) > Indeed, we're already planning to do it in other ways -- using a text field as a directly-instantiable class in the UI, for example. I don't really have much of an opinion on this discussion except that I'm not so negative about the original plan of writing our own backend as Jeremy is. Here are his objections: "From a technical standpoint, it's unclear how testing would work since our test_shell would be testing a different backend from what's in Chromium. It also means we have more code to maintain, and that code is completely off of WebKit's radar. It also makes Apple mad and Dimitri sad. So really, this doesn't seem like a good solution." I'm not sure how test_shell matters w.r.t. testing this backend, since the primary test of the backend (and the frontend?) would presumably be through unittests (w/mocks where necessary), which test the code directly and don't care what backend it's in. test_shell already doesn't have the same code as the main browser for 100 other things. Having code to maintain off WebKit's radar is again not a new situation. I'm not talking about forked stuff, just anything that isn't in WebKit. Having the code in WebKit is a two-edged sword, since when it's there it's gatekeepered on WebKit code review (not a big problem anymore since we have a couple reviewers now) and the WebKit community doesn't seem to try to keep their tree green. So IMO having code in WebKit is still just as much of a maintenance burden on us except with the additional hurdle that it's not in our direct tree. As far as making people mad, feh. Let's decide the right implementation first. But even if the original plan is IMO not so bad, I'm not opposed to the new plans either. People like Darin are much more qualified to comment on what would be *best* and I will be OK with whatever gets decided. PK --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
