In retrospect, this would probably be better as a V8 extension behind a
command-line flag.  That's probably what Darin meant to begin with. ;-)
Erik


On Thu, Apr 30, 2009 at 1:32 PM, Erik Kay <erik...@chromium.org> wrote:

> If anyone is interested in doing this extension work, come find myself or
> Aaron.  It's getting easier to add extension APIs.  We'd be happy to show
> you how.
> Erik
>
> On Thu, Apr 30, 2009 at 11:37 AM, Darin Fisher <da...@chromium.org> wrote:
>
>> I think if we should definitely make it possible to run layout tests in
>> Chrome.  However, supporting all of layout test controller will be a
>> considerable amount of work, and I think we always want to maintain the
>> simpler test_shell environment for exercising webkit divorced from the rest
>> of chrome (to help minimize flakiness).
>> Two ways forward: 1) build the layout test controller as an extension, 2)
>> build a new multi-process test_shell.  I think the first choice would be
>> best if we can pull it off.
>>
>> -Darin
>>
>>
>> On Wed, Apr 29, 2009 at 2:05 PM, Mike Belshe <mbel...@google.com> wrote:
>>
>>> We're still using the test-shell to run the LayoutTests.    I just fixed
>>> a bug, wrote a layout test, and then realized how dumb I was because the
>>> code I was testing was only in Chrome, and not in the test_shell.
>>>
>>> I think we're accumulating a lot of code that is chrome specific, but
>>> which could effect rendering and layout.  In my case, I'm working on v8
>>> extensions that have been put into the browser, but there is tons of code
>>> which differs between chrome and test shell.  Not having layout tests for
>>> chrome itself is making me a bit nervous.
>>>
>>> 2 Questions:
>>>
>>> 1) Any plans already underway to run chrome rather than test_shell
>>> through the Layout Tests?
>>>
>>> 2) Should we create those plans :-)
>>>
>>> Cheers,
>>> Mike
>>>
>>>
>>>
>>>
>>>
>>
>> >>
>>
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to