2009/5/21 Evan Martin <[email protected]> > I could make git-cl track what your patch was last uploaded against, > and warn on dcommit if that upload was not based on an upstream svn > commit. That would be pretty easy: > - on upload, stuff the diff base into a property of the branch > - on dcommit, call something like "git cat-file -p DIFFBASE | egrep > -q ^git-svn-id:" > > I seem to recall Paweł sending me a patch to do something like #1 but > it's probably buried in my inbox somewhere... :\
It was different. It stored Rietveld's patchset number, and I think it's applied. What do you think about another solution: add command git cl branch, which would remember from which branch did you branch off. Then it can check whether that branch is still associated with review issue (and still exists). This solution has its own fragility, i.e. you can later create a branch with same name. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
